Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#76 refactor image logo #88

Merged
merged 4 commits into from
Jan 17, 2021
Merged

Refactor/#76 refactor image logo #88

merged 4 commits into from
Jan 17, 2021

Conversation

Enessetere
Copy link
Collaborator

No description provided.

aleksanderwalczuk
aleksanderwalczuk requested changes Jan 17, 2021
View reviewed changes
Copy link
Owner

@aleksanderwalczuk aleksanderwalczuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove Logo.js file, paste code where Logo fn is being called.
  2. Conflicts

@DominikNowak
Copy link
Collaborator

  1. Remove Logo.js file, paste code where Logo fn is being called.
  2. Conflicts

It's already done in #81

@DominikNowak DominikNowak self-requested a review January 17, 2021 05:01
DominikNowak
DominikNowak approved these changes Jan 17, 2021
View reviewed changes
Copy link
Collaborator

@DominikNowak DominikNowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logo.js is already deleted in #81, so just solve conflicts with removing that file during merging. VisualImage seems to be ok :)

@DominikNowak DominikNowak mentioned this pull request Jan 17, 2021
Merged
@Enessetere Enessetere merged commit 3313c48 into feature/#23-menu-game-modes-ranking Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikNowak DominikNowak DominikNowak approved these changes

@vieraboschkova vieraboschkova vieraboschkova approved these changes

@aleksanderwalczuk aleksanderwalczuk Awaiting requested review from aleksanderwalczuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Enessetere @DominikNowak @aleksanderwalczuk @vieraboschkova